[
https://issues.apache.org/jira/browse/HBASE-5974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280728#comment-13280728
]
Anoop Sam John commented on HBASE-5974:
---------------------------------------
Thanks for the review Jieshan
{quote}
So what's your suggestion, Anoop? call CP hooks in the finally section?
{quote}
I mean in whatever case when we close the scanner we need to call the CP hooks.
Currently before this patch we were not doing this when getting a NSRE
{code}
catch (Throwable t) {
if (t instanceof NotServingRegionException) {
this.scanners.remove(scannerName);
}
throw convertThrowableToIOE(cleanup(t));
}
{code}
Here we can see it is not calling the CP hooks. As of now in case of the
cookie out of order also I am not contacting the CP hooks.
{quote}
RegionScanner scanner = scanners.get(scannerIdString).s;
{quote}
Oh yes. Thanks for pointing it out. I will fix.. This was not in that direct
next() call flow.. That is why I missed..:(
> Scanner retry behavior with RPC timeout on next() seems incorrect
> -----------------------------------------------------------------
>
> Key: HBASE-5974
> URL: https://issues.apache.org/jira/browse/HBASE-5974
> Project: HBase
> Issue Type: Bug
> Components: client, regionserver
> Affects Versions: 0.90.7, 0.92.1, 0.94.0, 0.96.0
> Reporter: Todd Lipcon
> Priority: Critical
> Attachments: HBASE-5974_0.94.patch
>
>
> I'm seeing the following behavior:
> - set RPC timeout to a short value
> - call next() for some batch of rows, big enough so the client times out
> before the result is returned
> - the HConnectionManager stuff will retry the next() call to the same server.
> At this point, one of two things can happen: 1) the previous next() call will
> still be processing, in which case you get a LeaseException, because it was
> removed from the map during the processing, or 2) the next() call will
> succeed but skip the prior batch of rows.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
