[GitHub] [hbase] clarax commented on a change in pull request #3356: HBASE-25973 Balancer should explain progress in a better way in log

[GitBox]

clarax commented on a change in pull request #3356:
URL: https://github.com/apache/hbase/pull/3356#discussion_r647719707



##########
File path: 
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -555,10 +564,10 @@ private String functionCost() {
     for (CostFunction c : costFunctions) {
       builder.append(c.getClass().getSimpleName());
       builder.append(" : (");
-      if (c.isNeeded()) {
-        builder.append(c.getMultiplier());
+      if (c.isNeeded() || c.getMultiplier() > 0) {
+          builder.append("multiplier=" + c.getMultiplier());

Review comment:
       Actually this is not needed. There are some confusion in other part of 
the code on negative multipliers but it shouldn't happen. Will clean up.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org