[ https://issues.apache.org/jira/browse/HBASE-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282168#comment-13282168 ]
Zhihong Yu commented on HBASE-6033: ----------------------------------- {code} + } + else { {code} Please move else to the end of line above. {code} + while (state == CompactionState.NONE && curt < endt) { + Thread.sleep(100); {code} Please use a shorter sleep interval. {code} + while (state != CompactionState.NONE && curt < endt) { {code} Why do we have a similar loop the second time ? {code} + assertTrue(countAfter < countBefore); {code} Can we judge countAfter quantitatively to determine whether major compaction or minor compaction happened ? > Adding some fuction to check if a table/region is in compaction > --------------------------------------------------------------- > > Key: HBASE-6033 > URL: https://issues.apache.org/jira/browse/HBASE-6033 > Project: HBase > Issue Type: New Feature > Reporter: Jimmy Xiang > Assignee: Jimmy Xiang > Attachments: hbase-6033_v2.patch, hbase-6033_v3.patch, > hbase_6033_v5.patch, hbase_6033_v6.patch, table_ui.png > > > This feature will be helpful to find out if a major compaction is going on. > We can show if it is in any minor compaction too. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira