[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382087#comment-17382087 ]
Hudson commented on HBASE-26083: -------------------------------- Results for branch master [build #344 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/344/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/344/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/344/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/344/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > L1 miss metric is incorrect when using CombinedBlockCache > --------------------------------------------------------- > > Key: HBASE-26083 > URL: https://issues.apache.org/jira/browse/HBASE-26083 > Project: HBase > Issue Type: Bug > Components: BlockCache > Reporter: Yutong Xiao > Assignee: Yutong Xiao > Priority: Minor > Fix For: 2.3.6, 3.0.0-alpha-2, 2.4.5, 1.7.2 > > > In CombinedBlockCache getBlock method > {code:java} > public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, > boolean repeat, boolean updateCacheMetrics) { > // TODO: is there a hole here, or just awkwardness since in the lruCache > getBlock > // we end up calling l2Cache.getBlock. > // We are not in a position to exactly look at LRU cache or BC as > BlockType may not be getting > // passed always. > return l1Cache.containsBlock(cacheKey)? > l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): > l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); > } > {code} > If L1 does not contains cacheKey, it will never check it in L1, so that L1 > miss metrics is always 0. -- This message was sent by Atlassian Jira (v8.3.4#803005)