shahrs87 commented on a change in pull request #3504:
URL: https://github.com/apache/hbase/pull/3504#discussion_r672625917
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestBasicWALEntryStream.java
##########
@@ -716,4 +717,52 @@ public void testCleanClosedWALs() throws Exception {
assertEquals(0, logQueue.getMetrics().getUncleanlyClosedWALs());
}
}
+
+ /**
+ * Tests that we handle EOFException properly if the wal has moved to
oldWALs directory.
+ * @throws Exception exception
+ */
+ @Test
+ public void testEOFExceptionInOldWALsDirectory() throws Exception {
+ assertEquals(1, logQueue.getQueueSize(fakeWalGroupId));
+ AbstractFSWAL abstractWAL = (AbstractFSWAL)log;
Review comment:
@bharathv It is needed. We are getting the current wal file name via
AbstractFSWAL#getCurrentFileName so that we can truncate that wal file to
create 0 size wal file. WAL class doesn't have this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
