Apache9 commented on a change in pull request #3504:
URL: https://github.com/apache/hbase/pull/3504#discussion_r673193521
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
##########
@@ -316,9 +316,8 @@ private boolean openNextLog() throws IOException {
return false;
}
- private Path getArchivedLog(Path path) throws IOException {
+ Path getArchivedLog(Path path) throws IOException {
Review comment:
Let's move this method to a util class so we do not need to change the
modifier and also do not need to pass the WALEntryStream to the
handleEofException?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -166,6 +169,9 @@ public void run() {
} catch (InterruptedException e) {
LOG.trace("Interrupted while sleeping between WAL reads or adding WAL
batch to ship queue");
Thread.currentThread().interrupt();
+ } finally {
Review comment:
What is the advantage here to not use try-with-resources but a try
finally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
