Apache9 commented on a change in pull request #3504:
URL: https://github.com/apache/hbase/pull/3504#discussion_r673995889
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractFSWALProvider.java
##########
@@ -500,6 +499,39 @@ public static Path getArchivedLogPath(Path path,
Configuration conf) throws IOEx
}
}
+ /**
+ * Get the archived WAL file path
+ * @param path - active WAL file path
+ * @param conf - configuration
+ * @return archived path if exists, path - otherwise
+ * @throws IOException exception
+ */
+ public static Path getArchivedLog(Path path, Configuration conf) throws
IOException {
Review comment:
Good. I think you have found potential bugs in our code base. We should
change them all to make use of the new method you introduced in this PR.
Suggest opening a new PR to address the incorrect usages of getArchivedLogPath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
