[
https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283986#comment-13283986
]
Igal Shilman commented on HBASE-6071:
-------------------------------------
Thanks for commenting, I would like to clarify:
bq. My original intention was using the above debug log to facilitate finding
root cause.
Our 0.90.4 production clients are already patched, following your suggestion
from the mailing list.
We are still waiting for the original error to occur (it happens infrequently)
and when it'll happen I'll report back w/ the details.
bq. It would be nice if debug log is added to 0.90 release you're using and see
what we get.
I have also prepared a patch for the 0.90 branch, backporting
hbase.client.log.scanner.activity to the ScannerCallable. If it has any value
besides debugging our case, I'd be happy to submit it.
bq. getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
I understand that trunk's ScannerCallable has a
hbase.client.log.scanner.activity option, that enables logging failures from
the scanner's side, yet ServerCallable along w/ its retry facility is being
used by others as well, so they are still affected by the issue reported in
this JIRA. Therefore, following your initial intention, I'm suggesting the
patch for the trunk (+ backport, if approved) that simply logs an exception at
each retry.
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
> Key: HBASE-6071
> URL: https://issues.apache.org/jira/browse/HBASE-6071
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Igal Shilman
> Priority: Minor
> Labels: client, ipc
> Attachments: HBASE-6071.patch,
> HConnectionManager_HBASE-6071-0.90.0.patch
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an
> exception different then a DoNotRetryIOException, thus silently drops
> exceptions from previous attempts.
> [~ted_yu] suggested
> ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E])
> adding a log message inside the catch block describing the exception type
> and details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
