[ 
https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392276#comment-17392276
 ] 

Duo Zhang commented on HBASE-26158:
-----------------------------------

{quote}
The reason why we can't use curator-test is that there's no way I can see to 
inject HBaseTestingUtility with a curator-test TestingServer instead of an 
MiniZookeeperCluster. So we have to inject a MiniZookeeperCluster into the 
custom process's in-process test harness. The test just wouldn't work with 
curator-test.
{quote}

So the solution is very clear then. We could provide configs for 
TestingHBaseCluster to not start a mini zookeeper cluster and the mini dfs 
cluster. And I need to correct you that, you do not need to inject the HBTU 
with a curator-test TestingServer, you just need to set configurations to let 
HBase use the zookeeper you start outside HBTU, it is 'hbase.zookeeper.quorum'. 
You need to set this when actually starting a hbase cluster in production 
right? Just set it in UT too.

Again, HBase is not designed to provide a utility class to start zookeeper, it 
is the duty for the zookeeper related projects.

Thanks.

> MiniZooKeeperCluster should not be IA.Public
> --------------------------------------------
>
>                 Key: HBASE-26158
>                 URL: https://issues.apache.org/jira/browse/HBASE-26158
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API, test
>            Reporter: Duo Zhang
>            Priority: Major
>
> End users do not need to test HBase when zookeeper is broken. And if users 
> want to start only a zookeeper cluster, they can just use curator-test, so I 
> do not think we should expose this class as IA.Public.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to