Apache9 commented on pull request #3460:
URL: https://github.com/apache/hbase/pull/3460#issuecomment-894215554


   > > Ping @wchevreuil @saintstack @z-york Any other concerns on this 
approach? If worth a try, I will merge this to a feature branch and start to 
implement file based tracking. Thanks.
   > 
   > I think this is good to go, @Apache9 . Are you planning to merge this on a 
separate feature branch, or the one created in 
[HBASE-24749](https://issues.apache.org/jira/browse/HBASE-24749)? It might 
conflict with the works I had made there for flushes and compactions, but I 
think this refactoring basically dismisses those. The splits/merges one (still 
open), may still apply.
   
   Better on another feature branch, I think this is another abstraction way 
comparing to HBASE-24749. We could work together on the following issues on how 
to better implement merge and split, with this abstraction way, and also how to 
integrate the region based tracking way which has already been implemented on 
branch HBASE-24749. If these things all work, then I think we could unify these 
two feature branches. If not, I think we need to go back to the design doc to 
discuss again. The goal of this issue is to make the store file tracking way 
pluggable so we will all be happy.
   
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to