[
https://issues.apache.org/jira/browse/HBASE-26176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396161#comment-17396161
]
Tak-Lon (Stephen) Wu edited comment on HBASE-26176 at 8/9/21, 5:01 PM:
-----------------------------------------------------------------------
hey [~psomogyi] I think we need one more change , for these two lines ,
especially the one in
[jenkins_precommit_github_yetus.sh|https://github.com/apache/hbase/blob/99a40ddacf19f7ae9d89cdc4778384ffd6a0e394/dev-support/jenkins_precommit_github_yetus.sh#L129-L135]
to make sure it works for the feature branch with prefix HBASE-*
[https://github.com/apache/hbase/blob/99a40ddacf19f7ae9d89cdc4778384ffd6a0e394/dev-support/jenkins_precommit_github_yetus.sh#L129-L135]
[https://github.com/apache/hbase/blob/99a40ddacf19f7ae9d89cdc4778384ffd6a0e394/dev-support/hbase_nightly_yetus.sh#L77-L84]
is there anyway to test it ... before we hit it again lol ?
was (Author: taklwu):
hey [~psomogyi] I think we need one more change , for these two lines ,
especially the one in
[jenkins_precommit_github_yetus.sh|https://github.com/apache/hbase/blob/99a40ddacf19f7ae9d89cdc4778384ffd6a0e394/dev-support/jenkins_precommit_github_yetus.sh#L129-L135]
to make sure it works for the feature branch with prefix HBASE-*
[https://github.com/apache/hbase/blob/99a40ddacf19f7ae9d89cdc4778384ffd6a0e394/dev-support/jenkins_precommit_github_yetus.sh#L129-L135]
https://github.com/apache/hbase/blob/99a40ddacf19f7ae9d89cdc4778384ffd6a0e394/dev-support/hbase_nightly_yetus.sh#L77-L84
> Correct regex in hbase-personality.sh
> -------------------------------------
>
> Key: HBASE-26176
> URL: https://issues.apache.org/jira/browse/HBASE-26176
> Project: HBase
> Issue Type: Bug
> Components: build
> Reporter: Peter Somogyi
> Assignee: Peter Somogyi
> Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6, 2.3.7
>
>
> When activating the Hadoop profile in hbase-personality.sh the regex also
> accepts branch-1 while it should only set the Hadoop profile for branch-2.
> https://github.com/apache/hbase/blob/master/dev-support/hbase-personality.sh#L151
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
