[ https://issues.apache.org/jira/browse/HBASE-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396919#comment-17396919 ]
William Volkman commented on HBASE-17104: ----------------------------------------- Well I might suggest removing the "Impossible!" part as it is happening across all of our region servers whenever HDFS takes longer than 30 seconds with a compaction request. This change is a better clarification than the original message, curious why it's still open? > Improve cryptic error message "Memstore size is" on region close > ---------------------------------------------------------------- > > Key: HBASE-17104 > URL: https://issues.apache.org/jira/browse/HBASE-17104 > Project: HBase > Issue Type: Bug > Components: regionserver > Reporter: Matteo Bertozzi > Assignee: Sahil Aggarwal > Priority: Trivial > Labels: beginner, noob > Attachments: HBASE-17104.master.001 (1) (1).patch, > HBASE-17104.master.001 (1).patch, HBASE-17104.master.001.patch > > > while grepping my RS log for ERROR I found a cryptic > {noformat} > ERROR [RS_CLOSE_REGION-u1604vm:35021-1] regionserver.HRegion(1601): Memstore > size is 33744 > {noformat} > from the code looks like we seems to want to notify the user about the fact > that on close the rs was not able to flush and there were things in the RS. > https://github.com/apache/hbase/blob/c3685760f004450667920144f926383eb307de53/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L1601 > {code} > if (!canFlush) { > this.decrMemstoreSize(new MemstoreSize(memstoreDataSize.get(), > getMemstoreHeapOverhead())); > } else if (memstoreDataSize.get() != 0) { > LOG.error("Memstore size is " + memstoreDataSize.get()); > } > {code} > this should probably not even be an error but a warn or even info, unless we > have puts that specifically asked to not be written to the wal, otherwise > the data in the memstore should be safe in the wals. > In any case it will be nice to have a message describing what is going on and > why we are notifying about the memstore size. -- This message was sent by Atlassian Jira (v8.3.4#803005)