bharathv commented on a change in pull request #3566: URL: https://github.com/apache/hbase/pull/3566#discussion_r688844196
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ########## @@ -308,18 +310,35 @@ */ private static final long DEFAULT_REGION_SERVER_RPC_MINIMUM_SCAN_TIME_LIMIT_DELTA = 10; - /* + /** * Whether to reject rows with size > threshold defined by * {@link RSRpcServices#BATCH_ROWS_THRESHOLD_NAME} */ private static final String REJECT_BATCH_ROWS_OVER_THRESHOLD = "hbase.rpc.rows.size.threshold.reject"; - /* + /** * Default value of config {@link RSRpcServices#REJECT_BATCH_ROWS_OVER_THRESHOLD} */ private static final boolean DEFAULT_REJECT_BATCH_ROWS_OVER_THRESHOLD = false; + /** + * Determine the bootstrap nodes we want to return to the client connection registry. + * <ul> + * <li>{@link #MASTER}: return masters as bootstrap nodes.</li> Review comment: ya okay. I understand your concern now. Thanks for the explanation. > If we really think we should remove this feature, then we'd better send a discussion email to dev list first. If there are no big concerns, then we can do this. +1 on this fwiw. Since the decision to inline masters in RW path was a wrong design choice, I vote to get rid of it in the long term. Patch lgtm otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org