Apache9 commented on a change in pull request #3583:
URL: https://github.com/apache/hbase/pull/3583#discussion_r689097857
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -753,8 +763,48 @@ private void initializeZKBasedSystemTrackers()
// Will be overriden in test to inject customized AssignmentManager
@InterfaceAudience.Private
- protected AssignmentManager createAssignmentManager(MasterServices master) {
- return new AssignmentManager(master);
+ protected AssignmentManager createAssignmentManager(MasterServices master,
+ MasterRegion masterRegion) {
+ return new AssignmentManager(master, masterRegion);
+ }
+
+ private void tryMigrateMetaLocationsFromZooKeeper() throws IOException,
KeeperException {
+ // try migrate data from zookeeper
+ try (ResultScanner scanner =
+ masterRegion.getScanner(new
Scan().addFamily(HConstants.CATALOG_FAMILY))) {
+ if (scanner.next() != null) {
+ // notice that all replicas for a region are in the same row, so the
migration can be
+ // done with in a one row put, which means if we have data in root
table then we can make
+ // sure that the migration is done.
+ LOG.info("Root table already has data in it, skip migrating...");
Review comment:
Later we will log what we have here, when loading meta, in
AssignmentManager.start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
