Apache9 commented on a change in pull request #3617:
URL: https://github.com/apache/hbase/pull/3617#discussion_r695378202
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
##########
@@ -648,11 +651,35 @@ public Path commitDaughterRegion(final RegionInfo
regionInfo)
if (!rename(daughterTmpDir, regionDir)) {
throw new IOException("Unable to rename " + daughterTmpDir + " to " +
regionDir);
}
+ loadRegionFilesIntoStoreTracker(regionDir);
}
-
return regionDir;
}
+ private void loadRegionFilesIntoStoreTracker(Path regionDir) throws
IOException {
Review comment:
I think here we need a big refactoring. First we need to create a
StoreFileTracker for the parent region(s), or maybe even StoreEngine, and then
load the store file list from the StoreFileTracker, and then, we do
split/merge, link the store files to the sub region data directory(s), and
then, create StoreFileTrakcer or StoreEngine for the sub region(s), insert the
store file list to it(them).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
