bbeaudreault opened a new pull request #3660: URL: https://github.com/apache/hbase/pull/3660
I made one important design decision in this implementation: This new option _only_ reloads the _balancer's_ config, not any other observers. It would be easy to simply call configurationManager.notifyObservers instead, but I felt like even with docs it would be too unexpected to have a balancer-specific option reload all configurations for the entire HMaster. If there are strong opposing opinions, perhaps we could name the option `setReloadAllMasterConfigs` or something. This would probably be safe,r but just feels like scope creep for the balancer command. I added a test for this new feature and it exposed an existing bug with reloading configs for the balancer. I will call out the fix with a line-item comment below. I also noticed and fixed another small logging bug which you'll see in StochasticLoadBalancer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
