huaxiangsun commented on a change in pull request #3661: URL: https://github.com/apache/hbase/pull/3661#discussion_r703800462
########## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java ########## @@ -392,17 +405,41 @@ public static Scan extractScanFromConf(Configuration conf) throws IOException { SNAPSHOT_INPUTFORMAT_SCAN_METRICS_ENABLED_DEFAULT); scan.setScanMetricsEnabled(scanMetricsEnabled); + boolean useRegionLoc = conf.getBoolean(SNAPSHOT_INPUTFORMAT_LOCALITY_BY_REGION_LOCATION, + SNAPSHOT_INPUTFORMAT_LOCALITY_BY_REGION_LOCATION_DEFAULT); + + Connection connection; + RegionLocator regionLocator = null; + if (localityEnabled && useRegionLoc) { + connection = ConnectionFactory.createConnection(new Configuration(conf)); Review comment: Hi @anoopsjohn, I pushed updates based on your comment, please take a look, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org