nyl3532016 commented on a change in pull request #3538:
URL: https://github.com/apache/hbase/pull/3538#discussion_r706015667



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2256,6 +2256,17 @@ void cloneTableSchema(TableName tableName, TableName 
newTableName, boolean prese
    */
   boolean isCompactionOffloadEnabled() throws IOException;
 
+  /**
+   * update compaction server total throughput bound
+   * @param upperBound the total throughput upper bound of all compaction 
servers
+   * @param lowerBound the total throughput lower bound of all compaction 
servers
+   * @param offPeak the total throughput offPeak bound of all compaction 
servers
+   * @return the now total throughput of all compaction servers
+   * @throws IOException if a remote or network exception occurs
+   */
+  Map<String, Long> updateCompactionServerTotalThroughput(Long upperBound, 
Long lowerBound,

Review comment:
       Yes, We do not control regionserver's compaction throughtput in this PR, 
 For HRegionserver can adjust their compaction throughtput via update_config 
shell commend, no need restart server. They implement ConfigurationObserver 
interface.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to