Apache9 commented on a change in pull request #3665:
URL: https://github.com/apache/hbase/pull/3665#discussion_r707837283
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java
##########
@@ -64,15 +127,30 @@ public static Configuration
mergeConfigurations(Configuration global, TableDescr
.addStringMap(family.getConfiguration()).addBytesMap(family.getValues());
}
- static StoreFileTrackerBase create(Configuration conf, String configName,
+ /**
+ * Create store file tracker to be used as source or destination for
+ * {@link MigrationStoreFileTracker}.
+ */
+ static StoreFileTrackerBase createForMigration(Configuration conf, String
configName,
boolean isPrimaryReplica, StoreContext ctx) {
- String className =
+ String trackerName =
Preconditions.checkNotNull(conf.get(configName), "config %s is not set",
configName);
Class<? extends StoreFileTrackerBase> tracker;
try {
- tracker =
Class.forName(className).asSubclass(StoreFileTrackerBase.class);
- } catch (ClassNotFoundException e) {
- throw new RuntimeException(e);
+ tracker =
+
Trackers.valueOf(trackerName.toUpperCase()).clazz.asSubclass(StoreFileTrackerBase.class);
+ } catch (IllegalArgumentException e) {
+ // Fall back to them specifying a class name
+ try {
+ tracker =
Class.forName(trackerName).asSubclass(StoreFileTrackerBase.class);
+ } catch (ClassNotFoundException cnfe) {
+ throw new RuntimeException(cnfe);
+ }
Review comment:
This is already the fallback logic :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
