virajjasani commented on a change in pull request #3688:
URL: https://github.com/apache/hbase/pull/3688#discussion_r714566278



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##########
@@ -757,7 +757,7 @@ public boolean next(List<Cell> outResult, ScannerContext 
scannerContext) throws
         }
       } while ((cell = this.heap.peek()) != null);
 
-      if (count > 0) {
+      if (count > 0 || storeLimit > -1 && this.countPerRow > (storeLimit + 
storeOffset)) {

Review comment:
       nit: it might look too many brackets but for better readability, good to 
add an additional bracket after first OR operator `if (a || (b && c))` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to