[ 
https://issues.apache.org/jira/browse/HBASE-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285356#comment-13285356
 ] 

Andrew Purtell commented on HBASE-6114:
---------------------------------------

bq. Since TestCacheOnWrite is in io.hfile package, can TestCacheOnWriteInSchema 
be placed in the same package ?

I chose to put it in regionserver because it operates at the Store level, with 
schema details. It makes more sense here IMO, even though the second part of 
the test cares only about HFile blocks.

bq. That way getOnDiskSizeWithHeader() can be made package private.

This is a trivial change and the related methods are all public. Do you have an 
objection?
                
> CacheControl flags should be tunable per table schema per CF
> ------------------------------------------------------------
>
>                 Key: HBASE-6114
>                 URL: https://issues.apache.org/jira/browse/HBASE-6114
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.92.2, 0.96.0, 0.94.1
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>         Attachments: 6114-0.92-v2.patch, 6114-0.92.patch, 6114-0.94-v2.patch, 
> 6114-0.94.patch, 6114-trunk-v2.patch, 6114-trunk.patch
>
>
> CacheControl flags should be tunable per table schema per CF, especially
> cacheDataOnWrite, also cacheIndexesOnWrite and cacheBloomsOnWrite.
> It looks like Store uses CacheConfig(Configuration conf, HColumnDescriptor 
> family) to construct the CacheConfig, so it's a simple change there to 
> override configuration properties with values of table schema attributes if 
> present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to