wchevreuil commented on pull request #3693: URL: https://github.com/apache/hbase/pull/3693#issuecomment-934448076
> Saw previous commits having thrift modification included the generated classes as well. This way we won't have the new API in sync with the committed generated code. (Although why have generated code in the first place - I guess we don't want to force everyone to install Thrift?). Anyway, generated code removed, PTAL @wchevreuil I believe you're right, @nkalmar , and removing those generated classes is what causing the build failures now. @horvathdora , would you mind put those back, so that the build passes? Sorry for having confused you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
