[
https://issues.apache.org/jira/browse/HBASE-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285828#comment-13285828
]
nkeywal commented on HBASE-6109:
--------------------------------
bq. Rename TestLocker class to TestKeyLocker ?
Done.
bq. 'shares with' -> 'shared with'
Done.
bq. Indentation in AssignmentManager.addToRITandCallClose() was off. It would
be nice to correct the existing lines.
Done
bq. 'share synchronized' -> 'synchronized'. Remove the 'todo nli:' at the end.
Done
bq. Insert spaces around = sign.
Done.
bq. 'are in' -> 'is in'
Done
bq. Why not call the method clone() ?
We don't really want the NotifiableConcurrentSkipListMap to be cloneable:
however, some functions want to work on a copy of the data structure, for
reporting or test (with all the 'Map' semantic), hence the internal clone.
bq. Suppose delegatee is empty upon entry to the above method, what if an entry
is added after the isEmpty() check ?
It will be equivalent to adding it just after the clear.
bq. 'A number' -> 'The number'
Done.
bq. 'number of people' -> 'number of users'
Done
bq. 'it's equals to zero.' -> 'it's equal to zero.'
Done
bq. The outer class is generic. The inner class shouldn't mention Region.
Done
> Improve RIT performances during assignment on large clusters
> ------------------------------------------------------------
>
> Key: HBASE-6109
> URL: https://issues.apache.org/jira/browse/HBASE-6109
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6109.v19.patch, 6109.v7.patch
>
>
> The main points in this patch are:
> - lowering the number of copy of the RIT list
> - lowering the number of synchronization
> - synchronizing on a region rather than on everything
> It also contains:
> - some fixes around the RIT notification: the list was sometimes modified
> without a corresponding 'notify'.
> - some tests flakiness correction, actually unrelated to this patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
