[GitHub] [hbase] joshelser commented on a change in pull request #3743: HBASE-26350 Add a DEBUG when we fail the SASL handshake

[GitBox]

joshelser commented on a change in pull request #3743:
URL: https://github.com/apache/hbase/pull/3743#discussion_r727332522



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java
##########
@@ -372,6 +372,7 @@ public void saslReadAndProcess(ByteBuff saslToken) throws 
IOException,
         replyToken = saslServer.evaluateResponse(saslToken.hasArray()?
             saslToken.array() : saslToken.toBytes());
       } catch (IOException e) {
+        RpcServer.LOG.debug("Failed to execute SASL handshake", e);

Review comment:
       Yup! slf4j largely prevents this from being an expensive call (the pain 
is often concatenating the strings together).
   
   Thanks for looking!

##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java
##########
@@ -372,6 +372,7 @@ public void saslReadAndProcess(ByteBuff saslToken) throws 
IOException,
         replyToken = saslServer.evaluateResponse(saslToken.hasArray()?
             saslToken.array() : saslToken.toBytes());
       } catch (IOException e) {
+        RpcServer.LOG.debug("Failed to execute SASL handshake", e);

Review comment:
       Good question. Only because that's what every other log message in this 
class does.
   
   I'm guessing this was an attempt to consolidate RPC debugging to a single 
class (when we had both NIO and Netty impls), but I'm not 100% sure.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org