z-york commented on pull request #3679: URL: https://github.com/apache/hbase/pull/3679#issuecomment-941670805
> > I had solved this by just creating the walsDir here if it didn't exist, is there a reason you decided to skip it instead of create the dir? If we just create the directory it will naturally be empty and skip the rest of the "replayWals" function that you added. > > No intentional reason :). It looks like `MasterRegion#createWAL()` is already doing the `mkdirs()` on the WAL dir. Happy to change if you feel strongly. Nope, I don't feel strongly. Feel free to merge once Duo signs off on the method naming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
