wchevreuil commented on a change in pull request #3749:
URL: https://github.com/apache/hbase/pull/3749#discussion_r728424375
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloneSnapshotProcedure.java
##########
@@ -453,56 +453,24 @@ private void postCloneSnapshot(final MasterProcedureEnv
env)
List<RegionInfo> newRegions,
final CreateHdfsRegions hdfsRegionHandler) throws IOException {
final MasterFileSystem mfs = env.getMasterServices().getMasterFileSystem();
- final Path tempdir = mfs.getTempDir();
Review comment:
Snapshots recover is another feature that was relying on temdirs &
renames. I took the decision to allow restored dirs being created on the final
path already, my understanding is that tables being restored/cloned will not be
enabled, and if the snapshot fails at this stage, it will not get to the meta
updates stages, meaning there will be no inconsistencies. There would be the
need to identify and cleanout leftovers of failed snapshot recoveries. Any
thoughts/suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
