[ https://issues.apache.org/jira/browse/HBASE-26404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436796#comment-17436796 ]
Rushabh Shah commented on HBASE-26404: -------------------------------------- Thank you [~zhangduo] for the review and commit ! > Update javadoc for CellUtil#createCell with tags methods. > ---------------------------------------------------------- > > Key: HBASE-26404 > URL: https://issues.apache.org/jira/browse/HBASE-26404 > Project: HBase > Issue Type: Bug > Affects Versions: 2.4.8 > Reporter: Rushabh Shah > Assignee: Rushabh Shah > Priority: Major > Fix For: 2.5.0, 2.4.9 > > > We have the following methods in CellUtil class which are deprecated. We used > to use this method within custom COPROC to create cells with custom tags. We > deprecated them in 2.0.0 version and created a new class called RawCell which > is LimitedPrivate with visibility set to COPROC. There is no reference to > RawCell#createCell(Cell cell, List<Tag> tags) method in javadoc of > CellUtil#createCell methods which are now deprecated. This is not user > friendly. We should improve the javadoc within CellUtil#createCell(Cell, > tags) method. > {noformat} > /** > * Note : Now only CPs can create cell with tags using the CP environment > * @return A new cell which is having the extra tags also added to it. > * @deprecated As of release 2.0.0, this will be removed in HBase 3.0.0. > * > */ > @Deprecated > public static Cell createCell(Cell cell, List<Tag> tags) { > return PrivateCellUtil.createCell(cell, tags); > } > {noformat} > {noformat} > public static Cell createCell(Cell cell, byte[] tags) > public static Cell createCell(Cell cell, byte[] value, byte[] tags) { > {noformat} > This improvement is only applicable to branch-2 since we have removed these > methods in branch-3. -- This message was sent by Atlassian Jira (v8.3.4#803005)