YutSean commented on pull request #3809: URL: https://github.com/apache/hbase/pull/3809#issuecomment-957047568
> > There is no method of InetSocketAddress return the colon concat result directly for unresolved address. Every usage of our tostring method should be reviewed if there could get unresolved address. Besides, what about not to use tostring() method here but just concatenate the string ourselves (could provide a util function for hostname and port concatenation). > > I like the approach to provide a util function. We could go this way. But maybe we need to make sure that we will not call this toString method again in the future? It seems that it is hard to guarantee, every InetSocketAddress is resolved. So that this problem will occur when we use tostring of an unresolved Address. In this case, we should try to avoid calling toString() I think. Not sure if there are other points that we should concern about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org