[ 
https://issues.apache.org/jira/browse/HBASE-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gregory Chanan updated HBASE-5936:
----------------------------------

    Attachment: HBASE-5936-v3.patch

* Attached HBASE-5936-v3.patch *

I haven't run this through the full test suite yet, let's see what hadoopQA 
says.

Makes the following changes from previous patch:
- Removed some dead code from WritableRpcEngine.java
- Converted the offline method used by hbck as well
- Fix the test case problems.  The issue was that HConnectionManager was taking 
a remote exception (e.g. ServiceException) and throwing the underlying 
IOException.  The problem is the function was declared as throwing a 
ServiceException, so you get a fun UndeclaredThrowableException and lose the 
actual underlying exception.  Luckily, there were some test cases that checked 
the actual exception type.  I suspect all the RPC conversions we've done had 
this problem.  That said, I'm not sure if Jimmy's stuff relied on the old 
behavior, so let's see what hadoopQA says.
                
> Add Column-level PB-based calls to HMasterInterface
> ---------------------------------------------------
>
>                 Key: HBASE-5936
>                 URL: https://issues.apache.org/jira/browse/HBASE-5936
>             Project: HBase
>          Issue Type: Task
>          Components: ipc, master, migration
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5936-v3.patch, HBASE-5936.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't 
> also make this a subtask (apparently).
> This is for converting the column-level calls, i.e.:
> addColumn
> deleteColumn
> modifyColumn

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to