Apache9 commented on a change in pull request #3843: URL: https://github.com/apache/hbase/pull/3843#discussion_r747551342
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ########## @@ -2522,10 +2520,11 @@ protected OffPeakHours getOffPeakHours() { @Override public void onConfigurationChange(Configuration conf) { - this.conf = StoreUtils.createStoreConfiguration(conf, region.getTableDescriptor(), + Configuration storeConf = StoreUtils.createStoreConfiguration(conf, region.getTableDescriptor(), getColumnFamilyDescriptor()); - this.storeEngine.compactionPolicy.setConf(conf); - this.offPeakHours = OffPeakHours.getInstance(conf); + this.conf = storeConf; + this.storeEngine.compactionPolicy.setConf(storeConf); Review comment: OK, so the problem is here, the 'conf' here is the conf from the parameter, not 'this.conf'... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org