wchevreuil commented on a change in pull request #29:
URL: https://github.com/apache/hbase-filesystem/pull/29#discussion_r750478969
##########
File path:
hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/ZKTreeLockManager.java
##########
@@ -252,12 +253,31 @@ private synchronized void removeInMemoryLocks(Path p) {
}
}
- private boolean isBeneath(Path parent, Path other) {
- if (parent.equals(other)) {
+ /**
+ * Returns true iff the given path is contained beneath the parent path.
Review comment:
nit: typo "iff"
##########
File path:
hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/ZKTreeLockManager.java
##########
@@ -161,7 +161,7 @@ protected void writeUnlock(Path p) throws IOException {
get(p).writeLock().release();
Review comment:
This 'get' call creates the znode if it's not in the cache, so call to
writeUnlock after deleting the znode would create it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
