virajjasani edited a comment on pull request #3852: URL: https://github.com/apache/hbase/pull/3852#issuecomment-971428634
The only case that might require behaviour change is when user specifies TTL 0: ``` > snapshot 'mytable', 'snapshot1234', {TTL => 0} ``` This snapshot would also be eligible to be deleted as per config `hbase.master.snapshot.ttl` because this config is applicable at entire cluster. If use specifies TTL value less than -1, then that snapshot will never be deleted based on TTL. Here is the current behaviour: 1. If client wants to create specific snapshot that should live forever regardless of `hbase.master.snapshot.ttl` config value, then they should specify TTL < -1. e.g `snapshot 'mytable', 'snapshot1234', {TTL => -2}` 2. If we don't want to enable TTL at entire cluster level, no need of any config change because the default value of `hbase.master.snapshot.ttl` is 0, which represents TTL Forever at server side. It's also important to note that SnapshotCleanerChore can be enabled/disabled using shell command: `snapshot_cleanup_switch`. More details in the section `Enable/Disable Snapshot Auto Cleanup on running cluster` [here](http://hbase.apache.org/book.html#ops.snapshots.takeasnapshot) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org