Apache9 commented on a change in pull request #3831:
URL: https://github.com/apache/hbase/pull/3831#discussion_r753798016
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
##########
@@ -299,4 +299,11 @@
* if you try to set a configuration.
*/
Configuration getReadOnlyConfiguration();
+
+ /**
+ * @return the identifier string of a store, formatted to
encodeRegionName:familyName
+ */
+ default String getIdentifier() {
Review comment:
The name seems too general...
Could we use just identity hash map to put the store instance in it directly?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -7050,11 +7053,15 @@ String prepareBulkLoad(byte[] family, String srcPath,
boolean copyFile)
HStore store = getStore(family);
try {
if (this.rsServices != null && store.needsCompaction()) {
- this.rsServices.getCompactionRequestor().requestCompaction(this,
store,
- "bulkload hfiles request compaction", Store.PRIORITY_USER + 1,
- CompactionLifeCycleTracker.DUMMY, null);
- LOG.debug("bulkload hfiles request compaction region : {},
family : {}",
- this.getRegionInfo(), family);
+ if
(!this.rsServices.getCompactionRequestor().isUnderCompaction(store)) {
Review comment:
Will needsCompaction returns true if the store is already under
compaction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
