zhengzhuobinzzb commented on a change in pull request #3876:
URL: https://github.com/apache/hbase/pull/3876#discussion_r755772858
##########
File path:
hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationQueueStorage.java
##########
@@ -417,6 +417,11 @@ public long getWALPosition(ServerName serverName, String
queueId, String fileNam
}
// add delete op for peer
listOfOps.add(ZKUtilOp.deleteNodeFailSilent(oldQueueNode));
+ // Append new queue id for prevent lock competition in zookeeper server.
+ String claimLockZNode = ZNodePaths.joinZNode(queuesZNode, "cversion_" +
newQueueId);
+ // update cversion for queuesZNode
+ listOfOps.add(ZKUtilOp.createAndFailSilent(claimLockZNode,
HConstants.EMPTY_BYTE_ARRAY));
Review comment:
You are right, I added more comments and documentation to explain why we
update the root queuesZNode and the relationship between claimQueue and
getAllWALs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
