[ 
https://issues.apache.org/jira/browse/HBASE-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287350#comment-13287350
 ] 

Hadoop QA commented on HBASE-6146:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12530537/HBASE-6146_Trunk.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestReplication

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2082//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2082//console

This message is automatically generated.
                
> Disabling of Catalog tables should not be allowed
> -------------------------------------------------
>
>                 Key: HBASE-6146
>                 URL: https://issues.apache.org/jira/browse/HBASE-6146
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-6146_94.patch, HBASE-6146_Trunk.patch
>
>
> HBaseAdmin#disableTable() when called with META or ROOT table, it will pass 
> the disable instruction to Master and table is actually getting disabled. 
> Later this API call will fail as there is a call to 
> HBaseAdmin#isTableDisabled() which is having a check like 
> isLegalTableName(tableName).So this call makes the catalog table to be in 
> disabled state.
> We can have same kind of isLegalTableName(tableName) checks in disableTable() 
> and enableTable() APIs

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to