bbeaudreault commented on pull request #3926: URL: https://github.com/apache/hbase/pull/3926#issuecomment-989203617
I took a closer look at the files you referenced. I actually think we _wouldn't_ have caught this, even if the hadoop version were correct. As far as I can tell, `hbase_nightly_pseudo-distributed-test.sh` is only testing `hbase-shaded-mapreduce` and `hbase-shaded-client-byo-hadoop`. I suppose we could add another step to that file which runs the same HBaseClientReadWriteExample.java but using `hbase-shaded-client` alone. Would making that change actually show up in these PR checks or only as part of some nightly process? Should we also bump the HADOOP3_VERSION, or run against both 3.1.1/3.3.1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
