Apache9 commented on a change in pull request #3947:
URL: https://github.com/apache/hbase/pull/3947#discussion_r775556015
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChunkCreator.java
##########
@@ -134,51 +134,36 @@ public static ChunkCreator getInstance() {
return instance;
}
- /**
- * Creates and inits a chunk. The default implementation for a specific
chunk size.
- * @return the chunk that was initialized
- */
- Chunk getChunk(ChunkType chunkType) {
- return getChunk(CompactingMemStore.IndexType.ARRAY_MAP, chunkType);
Review comment:
Mind explaining more? I do not understand...
I mean, in MemStoreLABImpl.getNewExternalChunk, we will call
getChunk(ChunkType), and then this method will use IndexType.ARRAY_MAP instead
of IndexType.CHUNK_MAP when creating a chunk, which means we could create a
Chunk with IndexType.ARRAY_MAP rather than IndexType.CHUNK_MAP in
MemStoreLABImpl.
And MemStoreLABImpl.getNewExternalChunk related methods have been called at
lots of places, is it safe to change them all the IndexType.CHUNK_MAP? Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
