[
https://issues.apache.org/jira/browse/HBASE-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289341#comment-13289341
]
Anoop Sam John commented on HBASE-6040:
---------------------------------------
Oh sorry.. I missed that part.
It is regarding the HFileDataBlockEncoder#saveMetadata(StoreFile.Writer
storeFileWriter)
In bulk load we deal with HFileWriter directly , not through StoreFileWriter.
The above call of saveMetadata() is happening from StoreFile.Writer#close()
only.
This call saveMetadata() only writes the encoder type into fileinfo
We might need to explicitly write this fileInfo from HFileOutputFormat.
HFileDataBlockEncoder#saveMetadata(StoreFile.Writer storeFileWriter)not sure
why this takes StoreFile.Writer rather than HFile.Writer
Other methods in this interface deals with HFile or HFile blocks.
@Stack I will reopen this JIRA?
Thanks Gopi for noticing this and raising. Regarding the point abt usage of
bloom we will track through other ticket (If ok)
> Use block encoding and HBase handled checksum verification in bulk loading
> using HFileOutputFormat
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-6040
> URL: https://issues.apache.org/jira/browse/HBASE-6040
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce
> Affects Versions: 0.94.0, 0.96.0
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 0.94.1
>
> Attachments: HBASE-6040_94.patch, HBASE-6040_Trunk.patch
>
>
> When the data is bulk loaded using HFileOutputFormat, we are not using the
> block encoding and the HBase handled checksum features.. When the writer is
> created for making the HFile, I am not seeing any such info passing to the
> WriterBuilder.
> In HFileOutputFormat.getNewWriter(byte[] family, Configuration conf), we dont
> have these info and do not pass also to the writer... So those HFiles will
> not have these optimizations..
> Later in LoadIncrementalHFiles.copyHFileHalf(), where we physically divide
> one HFile(created by the MR) iff it can not belong to just one region, I can
> see we pass the datablock encoding details and checksum details to the new
> HFile writer. But this step wont happen normally I think..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
