[ 
https://issues.apache.org/jira/browse/HBASE-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289487#comment-13289487
 ] 

Hadoop QA commented on HBASE-5609:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12530961/HBASE-5609-v3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 4 new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2106//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2106//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2106//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2106//console

This message is automatically generated.
                
> Add the ability to pass additional information for slow query logging
> ---------------------------------------------------------------------
>
>                 Key: HBASE-5609
>                 URL: https://issues.apache.org/jira/browse/HBASE-5609
>             Project: HBase
>          Issue Type: New Feature
>          Components: client, ipc
>            Reporter: Michael Drzal
>            Assignee: Michael Drzal
>            Priority: Minor
>         Attachments: HBASE-5609-v2.patch, HBASE-5609-v3.patch, 
> HBASE-5609.patch
>
>
> HBase-4117 added the ability to log information about queries that returned 
> too much data or ran for too long.  There is some information written as a 
> fingerprint that can be used to tell what table/column families/... are 
> affected.  I would like to extend this functionality to allow the client to 
> insert an identifier into the operation that gets output in the log.  The 
> idea behind this would be that if there were N places in the client 
> application that touched a given table in a certain way, you could quickly 
> narrow things down by inserting a className:functionName or similar 
> identifier.  I'm fully willing to go back on this if people think that it 
> isn't a problem in real life and it would just add complexity to the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to