[ 
https://issues.apache.org/jira/browse/HBASE-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290075#comment-13290075
 ] 

ramkrishna.s.vasudevan commented on HBASE-6012:
-----------------------------------------------

@Chunhui
Great stuff.

'alreadyOpendRegion' should be 'processAlreadyOpenedRegion'.
In the sendRegionOpen()  in the patch
{code}
    if (admin == null) {
      LOG.warn("Attempting to send OPEN RPC to server " + server.toString() +
        " failed because no RPC connection found to this server");
      return null;
{code}
we may need to handle FAILED_OPEN also.  May be it was not present but i think 
handling it here is necessary or else the znode will be created and no one will 
delete the znode. And subsequent bulk assign may cause the same issue reported 
here.
Others are great.  Lets see others reviews also.  Thanks Chunhui.

                
> Handling RegionOpeningState for bulk assign since SSH using
> -----------------------------------------------------------
>
>                 Key: HBASE-6012
>                 URL: https://issues.apache.org/jira/browse/HBASE-6012
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6012.patch, HBASE-6012v2.patch, HBASE-6012v3.patch
>
>
> Since HBASE-5914, we using bulk assign for SSH
> But in the bulk assign case if we get an ALREADY_OPENED case there is no one 
> to clear the znode created by bulk assign. 
> Another thing, when RS opening a list of regions, if one region is already in 
> transition, it will throw RegionAlreadyInTransitionException and stop opening 
> other regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to