Apache9 commented on pull request #4127: URL: https://github.com/apache/hbase/pull/4127#issuecomment-1052173660
Yes, I mean put the code where we check for sequence ids into the synchronized block too, they are all in memory operations, should not effect performance too much. And if a UT is really complicated, I suggest that we just add more comments to explain why we need to synchronized all the checks on sequence ids, instead of exposing so many internal things... Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
