[ 
https://issues.apache.org/jira/browse/HBASE-26745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell updated HBASE-26745:
----------------------------------------
    Fix Version/s: 2.5.0
                   2.6.0
                   3.0.0-alpha-3
                   2.4.11
           Status: Patch Available  (was: Open)

> MetricsStochasticBalancerSource metrics don't render in /jmx endpoint
> ---------------------------------------------------------------------
>
>                 Key: HBASE-26745
>                 URL: https://issues.apache.org/jira/browse/HBASE-26745
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Bryan Beaudreault
>            Assignee: Briana Augenreich
>            Priority: Minor
>              Labels: patch-available
>             Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.11
>
>
> The check in JSONBean 
> [here|https://github.com/apache/hbase/blob/master/hbase-http/src/main/java/org/apache/hadoop/hbase/util/JSONBean.java#L266]
>  causes the balancer cost metrics to be excluded from the {{/jmx}} endpoint. 
> I think we should just remove the check for ":". I don't think including 
> metrics with a colon in them poses any problem, since the strings are quoted. 
> We removed this check in our cdh5 fork almost a year ago and have not seen 
> any issues.
> Alternatively we can fix the MetricsStochasticBalancerSource metrics to emit 
> metrics that adhere to these filters, but I think that would be a backwards 
> incompatible change since this is only a json rendering issue and people 
> might be consuming JMX directly.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to