[ https://issues.apache.org/jira/browse/HBASE-26783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504759#comment-17504759 ]
Hudson commented on HBASE-26783: -------------------------------- Results for branch branch-2.4 [build #304 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/304/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/304/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/304/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/304/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/304/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > ScannerCallable doubly clears meta cache on retries > --------------------------------------------------- > > Key: HBASE-26783 > URL: https://issues.apache.org/jira/browse/HBASE-26783 > Project: HBase > Issue Type: Bug > Affects Versions: 2.4.10 > Reporter: Bryan Beaudreault > Assignee: Bryan Beaudreault > Priority: Major > Fix For: 2.5.0, 2.6.0, 2.4.11 > > > Way back in HBASE-15658 [~ghelmling] fixed RegionServerCallable to not clear > meta in {{{}prepare(boolean reload){}}}. because it already would have > cleared it in the try/catch when {{{}throwable(Throwable t, boolean > retrying){}}}. > I have recently been doing some load tests where I am causing HBase > RegionServers to throw many CallDroppedExceptions because they are overloaded > by the test. While this is an extreme example, it does sometimes crop up in > production when a bad actor executes a job without rate limiting, etc. What I > noticed was that the RegionServer hosting meta was most affected by the load, > way more than any other server in the cluster. Digging into the issue I > realized that the extra meta load was coming mostly from the scans, > originating from {{{}ScannerCallable.prepare(boolean reload){}}}. > I'm not sure why ScannerCallable was excluded from the original jira, maybe > an oversight. But ScannerCallable is called in the same context of > RetryingRpcCaller, which will handle clearing meta in the try/catch like > other callables. We should similarly update ScannerCallable's prepare method > not always pass useCache=true when getting region locations. -- This message was sent by Atlassian Jira (v8.20.1#820001)