thangTang commented on a change in pull request #4232:
URL: https://github.com/apache/hbase/pull/4232#discussion_r828800413
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
##########
@@ -249,7 +249,7 @@ private boolean checkAllBytesParsed() throws IOException {
+ ", which is too far away from reported file length " +
stat.getLen()
+ ". Restarting WAL reading (see HBASE-15983 for details). " +
getCurrentPathStat());
setPosition(0);
- resetReader();
+ openReader(currentPath, true);
Review comment:
@sunhelly Pls see
[WALEntryStream#resetReader](https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java#L391)
There will call _seek_ method, which means the resetReader also might
reposition the cursor somewhere, so i think we cannot just clear the
compressionContext.
As a temporary/staged fix, I think creating the reader directly is the least
invasive... What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
