[
https://issues.apache.org/jira/browse/HBASE-26617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514629#comment-17514629
]
Bryan Beaudreault commented on HBASE-26617:
-------------------------------------------
Yea I was thinking maybe it makes sense to wait a week or 2 before doing the
big format. In the meantime let people commit spotless cleanups in their
existing patches, for the files they are touching. So for my current PRs, once
they gets approval I can commit a single "spotless cleanup" commit.
The benefit of waiting is that it might flush out more issues like this before
we do a giant 100k line commit to reformat everything (like Andrew's branch-2.4
patch is).
I agree with Nick that I find his proposed change significantly easier to read
– a little more lines of code, but worth it?
> Use spotless to reduce the pain on fixing checkstyle issues
> -----------------------------------------------------------
>
> Key: HBASE-26617
> URL: https://issues.apache.org/jira/browse/HBASE-26617
> Project: HBase
> Issue Type: New Feature
> Components: build, community
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> https://github.com/diffplug/spotless
> Spotless is a tool for reformatting code based on your configuration file, it
> supports the google java format, as well as a eclipse formatter file.
> I think we could use it to format our code, based on a configuration file in
> our repo, and all the developpers, no matter what IDE they use, they can just
> type a mvn spotless:apply before commiting a PR, then everything is fine.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
