bbeaudreault commented on a change in pull request #4180: URL: https://github.com/apache/hbase/pull/4180#discussion_r839961863
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RemoteWithExtrasException.java ########## @@ -98,6 +111,11 @@ private IOException instantiateException(Class<? extends IOException> cls) throw cn.setAccessible(true); IOException ex = cn.newInstance(this.getMessage()); ex.initCause(this); + + if (ex instanceof HBaseServerException) { Review comment: This should be safe for existing users of `hbase.client.pause.cqtbe` as long as they upgrade the server first, then the client. If they don't, the boolean value passed in above will be false and we might erroneously downgrade a CQTBE to !isServerOverloaded. I'm going to look into tightening this up since I think we should honor the fact that the CQTBE constructor currently always passes `true` for isServerOverloaded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org