bbeaudreault commented on PR #4273: URL: https://github.com/apache/hbase/pull/4273#issuecomment-1102783179
I don't think we need an addendum for master. All of the extra commits here are just to support branch-2 specific functionality (i.e blocking client). HTableMultiplexer doesn't exist in master. The one divergence between master and branch-2 that might matter is the difference in in AsyncConnectionConfiguration, where here we instantiate a `new ConnectionConfiguration` in order to DRY up a bit. I thought about doing that in my master branch PR as well but it felt confusing since a bunch of fields have been removed from ConnectionConfiguration there and it almost seems like ConnectionConfiguration itself should be deleted in master branch. So I decided to leave it alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
