Apache9 commented on code in PR #4358:
URL: https://github.com/apache/hbase/pull/4358#discussion_r857761307
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java:
##########
@@ -447,6 +451,22 @@ protected final void closeZooKeeper() {
}
}
+ /**
+ * In order to register ShutdownHook, this method is called
+ * when HMaster and HRegionServer are started.
+ * For details, please refer to HBASE-26951
+ */
+ protected void intallShutdownHook() {
Review Comment:
And if this is not going to be extended, mark it final.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java:
##########
@@ -447,6 +451,22 @@ protected final void closeZooKeeper() {
}
}
+ /**
+ * In order to register ShutdownHook, this method is called
+ * when HMaster and HRegionServer are started.
+ * For details, please refer to HBASE-26951
+ */
+ protected void intallShutdownHook() {
Review Comment:
Typo, should be install
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
