[
https://issues.apache.org/jira/browse/HBASE-26989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529794#comment-17529794
]
David Manning commented on HBASE-26989:
---------------------------------------
When running the tests locally, I see these runtime improvements:
{{testNeedBalance}}: from 120 seconds to 11 seconds
{{testSloppyTablesLoadBalanceByTable}} 27 seconds to <1 second
{{testBalanceOfSloppyServers}} 67 seconds to <1 second
So total class {{TestStochasticLoadBalancer}} runtime reduces from 230 seconds
to 31 seconds.
Additionally, we get more deterministic behavior, since tests are more likely
to have consistent results with a max number of steps when compared to a max
running time.
> TestStochasticLoadBalancer has some slow methods, and inconsistent set,
> reset, unset of configuration
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-26989
> URL: https://issues.apache.org/jira/browse/HBASE-26989
> Project: HBase
> Issue Type: Test
> Components: Balancer, test
> Affects Versions: 3.0.0-alpha-1, 2.0.0
> Reporter: David Manning
> Assignee: David Manning
> Priority: Minor
>
> Some test ordering issues were exposed by adding new tests in HBASE-22349. I
> think this is a legitimate issue which is tracked in HBASE-26988.
> But we can update the tests to be consistent in how they update configuration
> to reduce confusion, removing the {{unset}} calls.
> We can also update other configuration values to significantly speed up the
> long-running methods. Methods that are simply checking for balancer plans do
> not need to {{runMaxSteps}}. All we need to do is run enough steps to
> guarantee we will plan to move one region. That can be far fewer than the
> tens of millions of steps we may be running given {{runMaxSteps}}.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
