d-c-manning commented on code in PR #4385:
URL: https://github.com/apache/hbase/pull/4385#discussion_r862256062
##########
hbase-balancer/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java:
##########
@@ -291,14 +293,15 @@ public void testUpdateStochasticCosts() {
} finally {
//reset config
conf.setFloat("hbase.master.balancer.stochastic.minCostNeedBalance",
minCost);
- conf.unset(HConstants.HBASE_MASTER_LOADBALANCE_BYTABLE);
+ conf.setBoolean(HConstants.HBASE_MASTER_LOADBALANCE_BYTABLE,
oldIsByTable);
Review Comment:
@shahrs87 I made the change. It's best viewed by using the "hide whitespace"
feature in github, because of the removal of `try` blocks. I think it cleans up
this test class nicely, even though it's a bigger scoped change. Thanks for the
recommendation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
